fix: pin sklearn for compat with model pickles#4
Open
ceholden wants to merge 1 commit into
Open
Conversation
ceholden
pushed a commit
that referenced
this pull request
Jun 2, 2026
Make FMask compatible with newer NumPy versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR pins the
scikit-learnpackage to the same major/minor version used by the model pickles. While I've had no issue running this withscikit-learn==1.8.0, it's risky to use different versions than what the pickle was saved as. Pickling models is an easy but complicated format for distributing trained models, and breakage across versions is one of the most common issues. A format like ONNX would be a better option for the future, but for now this PR locks the versions to stay in sync.This resolves the warning emitted: